Refactor song submission process to include YouTube metadata fetching; remove YouTube link requirement from settings for improved flexibility

server/game.js

@@ -28,8 +28,7 @@ class GameManager {
       settings: {
         songsPerPlayer: 3,
         maxPlayers: 10,
-        minPlayers: 3,
-        requireYoutubeLinks: false
+        minPlayers: 3
       },
       players: [{
         id: hostId,
@@ -300,15 +299,12 @@ class GameManager {
       return { error: 'Maximum number of songs reached' };
     }
     
-    // We only require the YouTube link now
-    if (!song.youtubeLink) {
-      return { error: 'YouTube link is required' };
-    }
-    
-    // If the YouTube link isn't valid, return an error
-    const videoId = await youtubeAPI.extractVideoId(song.youtubeLink);
-    if (!videoId) {
-      return { error: 'Invalid YouTube link' };
+    // If we have a YouTube link, validate it
+    if (song.youtubeLink) {
+      const videoId = await youtubeAPI.extractVideoId(song.youtubeLink);
+      if (!videoId) {
+        return { error: 'Invalid YouTube link' };
+      }
     }
     
     // Handle async metadata fetching
@@ -329,6 +325,20 @@ class GameManager {
     }
   }
   
+  /**
+   * Get metadata for a single YouTube video
+   * @param {string} videoId - YouTube video ID
+   * @returns {Promise<Object>} Video metadata
+   */
+  async getYouTubeVideoMetadata(videoId) {
+    try {
+      return await youtubeAPI.getVideoMetadata(videoId);
+    } catch (error) {
+      console.error('Error getting YouTube video metadata:', error);
+      return { error: 'Failed to get video metadata' };
+    }
+  }
+  
   /**
    * Helper method to add a song to a player
    * @param {number} playerIndex - Index of the player in the lobby

server/index.js

@@ -150,10 +150,11 @@ io.on('connection', (socket) => {
   });
   
   // Add a song
-  socket.on('add_song', ({ song }, callback) => {
+  socket.on('add_song', async ({ song }, callback) => {
     try {
       console.log(`[DEBUG] Attempting to add song: ${JSON.stringify(song)}`);
-      const result = gameManager.addSong(socket.id, song);
+      // Fix: Properly await the result of the async addSong function
+      const result = await gameManager.addSong(socket.id, song);
       
       if (result.error) {
         console.log(`[DEBUG] Error adding song: ${result.error}`);
@@ -225,6 +226,24 @@ io.on('connection', (socket) => {
     }
   });
   
+  // Get metadata for a single YouTube video
+  socket.on('get_video_metadata', async ({ videoId }, callback) => {
+    try {
+      if (!videoId || typeof videoId !== 'string') {
+        if (callback) callback({ error: 'Invalid video ID' });
+        return;
+      }
+      
+      const metadata = await gameManager.getYouTubeVideoMetadata(videoId);
+      
+      // Send response to client
+      if (callback) callback({ metadata });
+    } catch (error) {
+      console.error('Error getting YouTube metadata:', error);
+      if (callback) callback({ error: 'Failed to get YouTube metadata' });
+    }
+  });
+  
   // Mark player as ready
   socket.on('player_ready', (_, callback) => {
     try {