From 0f6ebeb7117b92ab38661a0cfaa94e0a0b953683 Mon Sep 17 00:00:00 2001 From: Mathias Wagner Date: Thu, 15 Feb 2024 19:51:37 +0100 Subject: [PATCH] Fixed response leaking --- .../java/de/gnmyt/mcdash/api/installer/PaperInstaller.java | 5 ++++- .../java/de/gnmyt/mcdash/api/installer/PurpurInstaller.java | 5 ++++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/src/main/java/de/gnmyt/mcdash/api/installer/PaperInstaller.java b/src/main/java/de/gnmyt/mcdash/api/installer/PaperInstaller.java index 60ce17e..53dd104 100644 --- a/src/main/java/de/gnmyt/mcdash/api/installer/PaperInstaller.java +++ b/src/main/java/de/gnmyt/mcdash/api/installer/PaperInstaller.java @@ -44,7 +44,10 @@ public class PaperInstaller implements VersionInstaller { okhttp3.Request request = new okhttp3.Request.Builder().url(String.format(PAPER_API, version)).build(); okhttp3.Response response = client.newCall(request).execute(); - return response.code() == 200; + boolean isValid = response.code() == 200; + response.close(); + + return isValid; } catch (Exception e) { LOG.error("An error occurred while checking the paper version", e); return false; diff --git a/src/main/java/de/gnmyt/mcdash/api/installer/PurpurInstaller.java b/src/main/java/de/gnmyt/mcdash/api/installer/PurpurInstaller.java index db32f82..ec2f665 100644 --- a/src/main/java/de/gnmyt/mcdash/api/installer/PurpurInstaller.java +++ b/src/main/java/de/gnmyt/mcdash/api/installer/PurpurInstaller.java @@ -21,7 +21,10 @@ public class PurpurInstaller implements VersionInstaller { Request request = new Request.Builder().url(String.format(PURPUR_URL, version)).build(); Response response = client.newCall(request).execute(); - return response.code() == 200; + boolean isValid = response.code() == 200; + response.close(); + + return isValid; } catch (Exception e) { LOG.error("An error occurred while checking the purpur version", e); return false;